On Tue, 6 Dec 2022 11:35:35 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> Simple fix to not requestFocus() on scene change. >> >> The attached bug sample shows that the TextField focused on the scene >> remains focused when the scene comes back. > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev excludes the unrelated > changes brought in by the merge/rebase. The pull request contains 29 > additional commits since the last revision: > > - Use utility class. > - Merge branch 'master' into 8296621_focus_stealing > - Merge branch 'openjdk:master' into master > - Add new line > - Use JUnit 5 > - Add test > - 8296621 - Stage steals focus on scene change > - Merge branch 'openjdk:master' into master > - Merge branch 'openjdk:master' into master > - Merge branch 'openjdk:master' into master > - ... and 19 more: https://git.openjdk.org/jfx/compare/43f465a7...8ce83fde I still need to do a little more testing, but so far, the fix looks good to me. As for the test, I left an inline comment answering your question. More importantly, though, the test doesn't catch the bug. It passes both with and without your fix on all three platforms. ------------- PR: https://git.openjdk.org/jfx/pull/940
