On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K <k...@openjdk.org> wrote:

>> Cause: When slider is dragged for first time after tooltip appears, 
>> setOnMousePressed event was not invoked, hence dragStart was null in the 
>> subsequently invoked event handler (setOnMouseDragged).
>> 
>> Fix: Initialized dragStart in initialize method.
>> 
>> Test: Added system test to validate the fix.
>> 
>> Note: Initializing dragStart in layoutChildren method as suggested in the 
>> bug was causing side effects. Hence initialized dragStart in initialize 
>> method.
>
> Karthik P K has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add check whether consumeAutoHidingEventsProperty is bound

The fix looks good to me. Please give @arapte time to comment on this, since he 
had raised earlier concerns.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/965

Reply via email to