On Fri, 9 Dec 2022 16:31:57 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add check whether consumeAutoHidingEventsProperty is bound
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/SliderSkin.java
>  line 410:
> 
>> 408:         thumb.setOnMouseExited(me -> {
>> 409:             Tooltip t = getSkinnable().getTooltip();
>> 410:             if (t != null && t.isAutoHide() && 
>> !t.consumeAutoHidingEventsProperty().isBound()) {
> 
> I still think a second property or a boolean might be better.  What if the 
> app code binds autoHidingEventsProperty after onMouseEntered?  I know this is 
> highly unlikely, but there is a potential.
> 
> At the same time, I  think we should proceed with this fix as it addresses a 
> problem which occurs always.

Agreed. Let's file a follow-on bug to consider the larger question of whether 
we should change the default value of `consumeAutoHidingEventsProperty` for 
Tooltip, so that they will not consume auto-hiding events by default.

-------------

PR: https://git.openjdk.org/jfx/pull/965

Reply via email to