On Mon, 12 Dec 2022 22:11:09 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 17 commits: >> >> - Merge branch 'openjdk:master' into feature/conditional-bindings >> - Remove example referencing Node#shownProperty >> - Remove changes to javafx.graphics Node >> - Improve wording in javadoc and comments >> - Adjust Node >> >> - Fixed javadoc >> - Added comment for code that avoid eager instantiation >> - Changed `isShown` to use property if it is available >> - Fix javadoc error >> - Fix comment in test >> - Improve documentation of shown property >> - Merge remote-tracking branch 'origin/master' into >> feature/conditional-bindings >> >> # Conflicts: >> # >> modules/javafx.base/src/test/java/test/javafx/beans/value/LazyObjectBindingTest.java >> - Fix review comments >> - ... and 7 more: https://git.openjdk.org/jfx/compare/8763e8b0...24872f09 > > modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueFluentBindingsTest.java > line 931: > >> 929: @Nested >> 930: class WithNotNullReturns_ObservableValue_Which { >> 931: private ObjectProperty<Boolean> condition = new >> SimpleObjectProperty<Boolean>(true); // using object property here so it >> can be set to null for testing > > Minor: can you wrap this line? (it's a fair bit longer than the recommended > max of 120 or so) Yeah, I tend to not wrap for comments after code and I forgot this one. I also noticed I could use diamond here now that I have my warnings on, so I fixed that as well. ------------- PR: https://git.openjdk.org/jfx/pull/830
