On Mon, 26 Dec 2022 03:26:14 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > modules/javafx.base/src/main/java/javafx/beans/binding/ListExpression.java > line 238: > >> 236: public Iterator<E> iterator() { >> 237: final ObservableList<E> list = get(); >> 238: return (list == null)? ListExpression.<E>emptyList().iterator() >> : list.iterator(); > > You're using three slightly different ways of referring to the empty list: > * `ListExpression.<E>emptyList()` > * `emptyList()` > * `EMPTY_LIST` > > What do you think about using the first option in all cases? I'm fine with that; the first two are equivalent, but in some cases I need to add the type witness to avoid a warning and you can only do that by adding the class name as well (ie. `<E>emptyList()` is not allowed, but `ListExpression.<E>emptyList()` is. ------------- PR: https://git.openjdk.org/jfx/pull/972