On Tue, 3 Jan 2023 23:07:19 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >> checkbox at once. If it does, only one checkbox (its skin) can actually use >> it as a scenegraph child, and it's not always the correct one. >> >> Added also a manual test app as I'm unsure about how to do an automatic test >> for this. The test app will be useful for later fixes, so I suggest adding >> it anyway. To test the fix, simply expand and collapse the root note >> repeatedly while it has a child. Before the fix the graphic will disappear >> after a few tries, after the fix it won't. You can test other hierarchies as >> well by adding children to the tree. > > tests/performance/checkboxTreeView/.classpath line 1: > >> 1: <?xml version="1.0" encoding="UTF-8"?> > > minor: should this project be moved to manual tests hierarchy? > > BTW, I am planning to create a monkey tester application which will include > many tests, to simplify the testing/verification of fixes JDK-8299335 > This code be added to the tester, either as a separate page, or as a data > source option for one of the TreeTableView page. I wasn't sure exactly where to put it, but it's going to be used in a fix for performance issue I found when a node has many children. If it will fit into a grater app I don't mind. ------------- PR: https://git.openjdk.org/jfx/pull/970
