On Thu, 5 Jan 2023 09:49:41 GMT, Karthik P K <k...@openjdk.org> wrote:
>> When Text width was more than TextField width, the logic to update >> `textTranslateX` in `updateCaretOff` method was causing the issue of >> unexpected behavior for Right and Center alignment. >> >> Made changes to update `textTranslateX` in `updateCaretOff` method only when >> text width is less than text field width i.e `delta` is positive. >> For both right and center alignments, the `textTranslateX` value calculated >> in `updateTextPos` method will be updated without any condition so that >> expected behavior is achieved for all scenarios of text width relative to >> text field width. >> >> Added unit tests to validate LEFT, CENTER and RIGHT alignments. RIGHT and >> CENTER alignment tests are expected to fail without the fix provided in this >> PR. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Update comments tested with the monkey tester https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/monkey/MonkeyTesterApp.java works beautifully with all the alignment settings. good job, Karthik! ------------- Marked as reviewed by angorya (Committer). PR: https://git.openjdk.org/jfx/pull/980
