On Thu, 2 Feb 2023 18:09:23 GMT, Andy Goryachev <[email protected]> wrote:
>>> one way to do it is to describe the expected result in the comment
>>> immediately preceding the string.
>>> ...
>>>
>>> Also, for testing purposes, we could consider pseudolocalization
>>
>> These are good suggestions that should be captured in the follow-up issue
>> that Alex said he will file.
>>
>> Localization and testing is out of scope for this PR. Alex did the minimum
>> needed to correct the fact that the string wasn't internationalized at all,
>> which makes sense only because he had to modify the string as part of this
>> PR (even then, I would have been OK with no i18n changes in this PR, leaving
>> them for a separate issue as well).
>>
>>> Better discuss this with Naoto Sato.
>>
>> Good idea.
>
> Definitely out of scope for this PR, I just wanted to mention this.
> @azuev-java please link the follow up JBS ticket for localization.
> Thank you!
Still, I would recommend adding a comment (since now is the time when we know
all the context, and in the future we might forget or lose the context), may be
something like
# {seriesName} {xAxisName} is {currentX} {yAxisName} is {currentY}
XYChart.series.accessibleText={0} {1} is {2} {3} is {4}
-------------
PR: https://git.openjdk.org/jfx/pull/1016
