On Fri, 3 Feb 2023 20:15:46 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> Fixed regression introduced by JDK-8295754, targeting upstream **jfx20 
> branch**.
> 
> The method PaginationSkin.resetIndexes(true) has been moved to the original 
> position in the constructor, fixing the initialization, while making sure no 
> properties of the control are touched in the constructor (only in install()).
> 
> Added a test case.
> 
> Tested with the PaginationDisappear.java and the LeakTest app
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTestApp.java

You are right!
In fact, the added logic to bypass setting control properties in the 
constructor is unnecessary - it will be essentially a no-op, since it uses the 
control's current page index.

-------------

PR: https://git.openjdk.org/jfx/pull/1021

Reply via email to