On Fri, 3 Feb 2023 23:09:30 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Fixed regression introduced by JDK-8295754, targeting upstream **jfx20 >> branch**. >> >> The method PaginationSkin.resetIndexes(true) has been moved to the original >> position in the constructor, fixing the initialization, while making sure no >> properties of the control are touched in the constructor (only in install()). >> >> Added a test case. >> >> Tested with the PaginationDisappear.java and the LeakTest app >> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTestApp.java > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8301797: review comments The simplified fix looks good to me! Thanks for fixing this regression. ------------- Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.org/jfx/pull/1021
