On Mon, 18 Jul 2022 12:18:49 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are added to the ticket. >> >> Removing the nested loop fixes the Problem. >> I hope this doesn't have any side effect - so far i don't know of any. > > Florian Kirmaier has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 10 commits: > > - JDK-8273485 > Fixing issue caused by wrong merge. > - Merge remote-tracking branch 'origin/master' into > JDK-8273485_swing-deadlock > > # Conflicts: > # modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m > - JDK-8273485 > Added check for null when calling initScreens > - JDK-8273485 > Fixing toggle fullscreen! > - JDK-8273485 > removed the toggle fullscreen before closing - to avoid the beep and > improve the user experience > - JDK-8273485 > Fixed Beep sound when closing a fullscreen window > - JDK-8273485 > small cleanup of the changes. > - JDK-8273485 > Removed the enter/leave nested event loop logic, for mac fullscreen > - JDK-8273485 > Added unit-test > - JDK-8273485 > Fixing deadlock when switching to fullscreen, when also swing is used. I would like to keep this PR. I've worked weeks on it, to make this work. It's now been tested quite a long in production. I understand that this is hard to test. But It removes code, adds a unit test, fixes a reproducible bug, and has been used for a long time in a Real World application. That's usually the kind of PR we want to accept. ------------- PR Comment: https://git.openjdk.org/jfx/pull/622#issuecomment-1493829584
