On Fri, 14 Apr 2023 09:47:45 GMT, John Hendrikx <[email protected]> wrote:
>> These changes use base classes for custom properties where possible for the
>> `ExpressionHelper` logic instead of duplicating these each time.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>
> Use property base classes where possible
Looks good to me.
modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java
line 44:
> 42: * an observable form.
> 43: */
> 44: public class TreeShowingExpression extends ReadOnlyBooleanPropertyBase {
Maybe you could rename the class to `TreeShowingProperty`?
-------------
PR Review: https://git.openjdk.org/jfx/pull/1092#pullrequestreview-1386286257
PR Review Comment: https://git.openjdk.org/jfx/pull/1092#discussion_r1167353328
