> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data > dirs" > Solution: > 1. All data directories must only be created under the "build" dir. In > addition to being a best practice, at least they will be cleaned up by > "gradle clean" > 2. There should be an @AfterClass method that deletes the data dirs > 3. There should be an @BeforeClass method that also deletes the data dirs > prior to running the tests in case it wasn't cleaned up previously
Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1100/files - new: https://git.openjdk.org/jfx/pull/1100/files/b3f57716..c42143f1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1100&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1100&range=00-01 Stats: 16 lines in 1 file changed: 7 ins; 5 del; 4 mod Patch: https://git.openjdk.org/jfx/pull/1100.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1100/head:pull/1100 PR: https://git.openjdk.org/jfx/pull/1100