On Thu, 20 Apr 2023 17:09:52 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data >> dirs" >> Solution: >> 1. All data directories must only be created under the "build" dir. In >> addition to being a best practice, at least they will be cleaned up by >> "gradle clean" >> 2. There should be an @AfterClass method that deletes the data dirs >> 3. There should be an @BeforeClass method that also deletes the data dirs >> prior to running the tests in case it wasn't cleaned up previously > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > remove webEngine.setUserDataDirectory(null) from all test cases Marked as reviewed by kcr (Lead). ------------- PR Review: https://git.openjdk.org/jfx/pull/1100#pullrequestreview-1394441431
