On Mon, 24 Apr 2023 15:03:47 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change call to requestFocus > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java > line 51: > >> 49: // empty - not needed by this implementation >> 50: @Override >> 51: protected native void _updateViewSize(long ptr); > > Is there a system test that can be used to verify these changes on Linux? > Since you have mentioned this is the same as #1054, I take that > SetSceneScalingTest can be used. > > Also, I'm not sure how you would run WinIconified test attached to the JBS > ticket to see that it fails or passes. If that can be converted to system > test, could you add it to this PR? I noticed this earlier, and filed [JDK-8298500](https://bugs.openjdk.org/browse/JDK-8298500) to improve our test coverage in this area. It would be good to make sure that we have a test that does this for at least an inconified window to help validate this PR. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1175879302
