On Mon, 24 Apr 2023 23:35:14 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> I replicated the fix on #1054 on Linux. >> >> Also fixes [Monocle: Stage no longer gets focus after fix for >> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev excludes the unrelated > changes brought in by the merge/rebase. The pull request contains 46 > additional commits since the last revision: > > - Review changes > - Merge branch 'master' into change_scene_fix > - Change call to requestFocus > - Revert "The window could start iconified." > > This reverts commit f92e25cbcc24fd772b9d6bb25a92386ec0561313. > - The window could start iconified. > - Request Focus on setVisible > - fix mistake > - Scene not rendered initially when changing scenes after fix for JDK-8296621 > - Merge branch 'openjdk:master' into master > - Merge branch 'openjdk:master' into master > - ... and 36 more: https://git.openjdk.org/jfx/compare/bd6d1fe9...2649d15c In general, this approach looks good to me. I agree having the `requestFocus` on `setVisible` instead of `setStage` makes more sense from a conceptual point. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1525578103
