On Wed, 3 May 2023 19:08:06 GMT, Alexander Zuev <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/manual/monkey/src/com/oracle/tools/fx/monkey/pages/ComboBoxPage.java
> line 71:
>
>> 69: new Timeline(
>> 70: new KeyFrame(Duration.seconds(1.0), (ev) -> {
>> 71: System.out.println("2");
>
> Why do we need that debug output in this particular place? May be add some
> label or text field that shows the currently assumed number of items instead
> of relying on the system output stream? Also it would be great if there is a
> text somewhere which at least describes what is the purpose of the button and
> what is supposed to happen when you press it. If not in some designated area
> then at least as a tooltip on the button? I mean "Change item count" - to
> what? No mention of the delay so user has to either guess of why does it not
> change immediately or look the source code.
good point, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1184152929
