On Wed, 3 May 2023 18:11:29 GMT, Alexander Zuev <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/manual/monkey/src/com/oracle/tools/fx/monkey/pages/AccordionPage.java
> line 61:
>
>> 59:
>> 60: protected void addPane() {
>> 61: String name = "" + System.currentTimeMillis();
>
> Here and in other demos - can we use some sort of pronounceable generated
> names for new controls instead of hashes or timestamps? Especially testing
> accessibility for system to voice the numbers soup takes a long time because
> it spells it out digit by digit and it is hard to check if we get reading
> from the correct component because names are like 99% the same. Even "Pane
> 1".."Pane 99" would be more acceptable.
changed to a global sequence number
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1184225400
