On Fri, 12 May 2023 21:26:51 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener
>> (which is ok in this particular situation) - the leak is specific to
>> TreeTableRowSkin.
>>
>> Added a unit test.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> John is right
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
line 158:
> 156: private void updateCachedFixedSize() {
> 157: if (getSkinnable() != null) {
> 158: TreeTableView<T> t = getSkinnable().getTreeTableView();
I know this is a short method, but I would rather see a more descriptive
variable name here
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
line 161:
> 159: if (t != null) {
> 160: double sz = t.getFixedCellSize();
> 161: fixedCellSize = sz;
Why you don't just assign the variable directly?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1193015659
PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1193015561
