On Mon, 15 May 2023 16:12:10 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener >> (which is ok in this particular situation) - the leak is specific to >> TreeTableRowSkin. >> >> Added a unit test. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 17 additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into 8307538.refresh > - review comments > - John is right > - review comments > - one more test case > - back to register listener > - weak lambdas are getting collected > - removed monkey tester changes > - Merge remote-tracking branch 'origin/master' into 8307538.refresh > - whitespace > - ... and 7 more: https://git.openjdk.org/jfx/compare/c0c029a0...f68de127 The fix looks good to me! ------------- Marked as reviewed by aghaisas (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1129#pullrequestreview-1462118493
