On Thu, 1 Jun 2023 20:26:33 GMT, Marius Hanl <[email protected]> wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 3085:
>
>> 3083: double newSize = isVertical() ?
>> cell.getLayoutBounds().getHeight() : cell.getLayoutBounds().getWidth();
>> 3084: itemSizeCache.set(cellIndex, newSize);
>> 3085: if ((oldSize != null) && !oldSize.equals(newSize)) {
>
> Minor: Braces are not needed here
I presume you mean parentheses. True, they aren't needed, but there is no harm
in leaving them.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1098#discussion_r1214233814
