On Fri, 21 Jul 2023 14:24:17 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> Is this new code or was it moved / refactored from elsewhere? If new code, > what is its purpose, and who is calling it? It was taken from last webkit update, as it was giving undefined reference error for current webkit update. > ``` > --- a/modules/javafx.web/src/main/native/Source/WebCore/dom/Element.cpp > +++ b/modules/javafx.web/src/main/native/Source/WebCore/dom/Element.cpp > @@ -2295,8 +2295,11 @@ URL Element::absoluteLinkURL() const > > if (linkAttribute.isEmpty()) > return URL(); > - > +#if PLATFORM(JAVA) > + return document().completeURL(linkAttribute); > +#else > return > document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkAttribute)); > +#endif > } > > #if ENABLE(TOUCH_EVENTS) > ``` > > Why did we need to make this change? Will there be any problems as a result > of our not stripping leading and trailing spaces? The code is taken from the WebKit upstream main. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1645983062 PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1645986867
