On Sun, 6 Aug 2023 07:45:54 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add newline at the end of the header files. > > modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line > 174: > >> 172: jobject jresult = NULL; >> 173: GET_MAIN_JENV; >> 174: if (env == NULL) return NULL; > > This generates a warning: > `warning: incompatible pointer to integer conversion returning 'void *' from > a function with result type 'BOOL' (aka 'signed char') [-Wint-conversion]` Good catch. This should probably be changed to: `return NO;` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1184#discussion_r1285921001
