On Mon, 14 Aug 2023 18:38:39 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:

>> also
>> 8309629: Create implementation of NSAccessibilityRadioButton protocol
>> 
>> Create implementation of NSAccessibilityCheckBox and 
>> NSAccessibilityRadioButton protocols
>> Add workaround for the wrong focus owner announcement with radio buttons
>> Add workaround for wrong magnifier text on buttons
>
> Alexander Zuev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Comment out TAB_ITEM until the TAB_GROUP is properly implemented in the new 
> API
>   Make isAccessibilityFocused to always return a proper value

> Providing a minor comment for a warning. Also noticed that, with this change 
> tab are read as radio button. [ Tested with ensemble ]
> 
> <img alt="Screenshot 2023-08-06 at 3 23 35 PM" width="646" 
> src="https://user-images.githubusercontent.com/11330676/258645623-1d9ade44-2305-4f13-afe3-2d586934a918.png";>

That seems to require the proper implementation of TAB_GROUP with the new API - 
mixing old and new API does not work here since in the existing code the 
accessible type reported is radio button but because parent encloses them in a 
tab group content it gets translated as tab item. Changing type to tab item 
without implementing tab group makes it loose the "Tab x out of y" notion so it 
is not the correct way to go. Commented out that assignment until tab group is 
implemented.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1184#issuecomment-1677893486

Reply via email to