On Thu, 17 Aug 2023 13:44:13 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/MediaPlayerPrivateJava.cpp >> line 436: >> >>> 434: // in case of hls media m3u8 format check network state >>> 435: // since jfx media do not support hls live streaming protocol >>> 436: if ( MediaPlayerNetworkState::NetworkError == >>> MediaPlayer::NetworkState::NetworkError) >> >> Are there other errors that might occur, or is this the only one you need to >> check? >> >> Minor: delete the extra space after the `(`. > > done The answer to my question is still pending. Please take a look at whether or not this is the only error you need to check. If it is, can you say why? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1212#discussion_r1297452432