> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares 
> two methods:
> - public ObservableMap<Object, Object> getProperties();
> - public boolean hasProperties();
> 
> 2. Node, MenuItem, and Toggle now extend ContainsProperties interface.
> 
> 3. Making implemented methods in Node, MenuItem, and Toggle final.
> 
> While this change is an improvement from a design point of view, it 
> introduces a larger compatibility risk (by adding 'final' keyword similar to 
> [JDK-8313651](https://bugs.openjdk.org/browse/JDK-8313651))
> 
> This change requires CSR.

Andy Goryachev has updated the pull request incrementally with one additional 
commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1215/files
  - new: https://git.openjdk.org/jfx/pull/1215/files/cd643cfd..effbc857

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1215&range=03
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1215&range=02-03

  Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jfx/pull/1215.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1215/head:pull/1215

PR: https://git.openjdk.org/jfx/pull/1215

Reply via email to