On Fri, 20 Oct 2023 02:50:28 GMT, Michael Strauß <[email protected]> wrote:
>> Sai Pradeep Dandem has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8185831: Minor change to remove extra line
>> - 8185831: Added testcase to verify when the selector ignores pseudo
>> classes when the nodes have same style class
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/Node_lookup_Test.java
> line 202:
>
>> 200: */
>> 201: @Test
>> 202: public void lookupPseudoTest3() {
>
> Consider naming the test methods according to what they test.
Renamed the methods by referring to method names used in other classes. I
noticed that descriptive long method names is accepted, so named similarly. The
only thing I want to check is: I renamed existing methods also. Is it accepted?
or I am not allowed to rename others method names?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1245#discussion_r1366406779
