On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad <d...@openjdk.org> wrote:

>> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>> 
>> Context: the warning might be more important than it seems. Our JavaFX-based 
>> desktop app has [an issue](https://github.com/defold/defold/issues/7845) — 
>> when the user opens 2 instances of the app, one of the instances hangs after 
>> a while. While debugging the issue, I found that it's somehow related to the 
>> system menu bar — not refreshing it fixes the issue. Further investigations 
>> revealed that the app hangs only if we show menus that use F1-F24 shortcuts. 
>> This reminded me of the warnings we get about `NSEventModifierFlagFunction 
>> specified to -setKeyEquivalentModifierMask` for such shortcuts. I 
>> experimented with removing the modifier for these shortcuts, and it helped 
>> with our issue!
>
> vlaaad has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   Don't use NSFunctionKeyMask as modifier at all

Verified that the OS warning message is gone and system menus still work as 
expected.

-------------

Marked as reviewed by belden...@github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jfx/pull/1252#pullrequestreview-1706571521

Reply via email to