On Wed, 8 Nov 2023 18:26:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add a system test
>
> tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 122:
> 
>> 120:             Thread.currentThread().setUncaughtExceptionHandler((t,e) -> 
>> {
>> 121:                 e.printStackTrace();
>> 122:                 failed.set(true);
> 
> To avoid the test hanging indefinitely, I recommend adding the following 
> after setting the `failed` flag:
> 
> 
>     memoryLatch.countDown();

good idea.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1277#discussion_r1387700709

Reply via email to