On Mon, 20 Nov 2023 05:37:38 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y 
> client application requests for it.
> Ideally we should use the text set by `Node.setAccessibleText()` as the 
> `UIA_NamePropertyId`.
> For other controls such as Slider, ListView we use the text set by 
> setAccessibleText() API.
> 
> Fix:
> Use the text set by `Node.setAccessibleText()` as the `UIA_NamePropertyId`.
> This means, when a11y client requests `UIA_NamePropertyId`, which is mapped 
> to AccessibleAttribute.TEXT attribute,  we shall return the accessible text.
> So we need another way to read out the VALUE of the Spinner.
> - For this we need to implement `IValueProvider` pattern for Spinner control
> - IValueProvider requests the value of the control using it's API 
> `get_ValueString()`
> - It required to introduce a new AccessibleAttribute `VALUE_STRING`
> - IValueProvider  also reads out if the control is editable or not, hence 
> added `EDITABLE `case in `Spinner.queryAccessibleAttribute()`
> 
> Verification:
> - Run any spinner app, with setAccessibleText set on spinner 
> - Run Windows narrator and observe
> - Without this fix:
> - 1. Narrator does not read the text set by setAccessibleText
> - 2. In application "Accessibility Insights for Windows", you can see the 
> value of Spinner as the Name property
> - After this fix:
> - 1. Narrator reads the accessible text then value of Spinner and then if 
> editable or not
> - 2. In application "Accessibility Insights for Windows", you can see the 
> text set by `setAccessibleText()` for Spinner as the Name property and the 
> Spinner's value as value property

This should be tested in connection with PR #1226

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1291#issuecomment-1819228774

Reply via email to