On Tue, 28 Nov 2023 18:58:57 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> combine > > modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 342: > >> 340: */ >> 341: public static List<CssMetaData<? extends Styleable, ?>> combine( >> 342: List<CssMetaData<? extends Styleable, ?>> list, > > Any reason this is specifically a `List`? Can it not be a `Collection`? It should have been a Set maybe, or indeed a Collection. But it is too late: Node codifies the List return values: public static List<CssMetaData<? extends Styleable, ?>> getClassCssMetaData(); public List<CssMetaData<? extends Styleable, ?>> getCssMetaData(); ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1296#discussion_r1408272938
