On Thu, 16 Nov 2023 06:50:36 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Yes, right now it is a bit magic. At least the first if can be simplified >> still, as `!= 4` will also handle `== 0`. > > I agree with Andy here. However the first condition can be simplified without > any side effects but I had seen some side effects if we remove second > condition. Hence simplified the first condition as suggested above and > maintained second condition as it is. we'll address this `== 4` logic once and if the new caret info API comes in. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1287#discussion_r1411063655
