On Sun, 14 Jan 2024 15:14:36 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> If this method is not used anywhere, why do we need to expose >> `getStyleClassNames()` as new API to replace this one? I'm a bit puzzled by >> that, especially since you're saying that the API shouldn't be used. Why >> create something that shouldn't be used? >> >> I'd rather just document that you shouldn't expect great performance from >> this method, and be done with it. Changing API in a performance optimization >> PR seems out of scope. > > @mstr2 I've created #1333 to show how it would look when we move > `SimpleSelector` and `CompoundSelector` to internal packages. I think that > should alleviate most concerns, and we can either integrate this first with a > new public method, which will later be internal anyway, or integrate the > other change first. Thanks for the detailed explanation. I agree that moving `SimpleSelector` and `CompoundSelector` to an internal package would be the best choice, and would also make the question of new API a non-issue. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1316#discussion_r1452732188
