On Fri, 19 Jan 2024 16:15:10 GMT, Martin Fox <m...@openjdk.org> wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are >> processed on the JavaFX application thread instead of the AWT EventQueue >> thread. This PR adds the runAndWait() calls to do that. >> >> This would be difficult to test on Windows without a fix for >> [JDK-8090267](https://bugs.openjdk.org/browse/JDK-8090267) so I've included >> the fix first proposed by @prsadhuk in PR #1169. If a developer uses the >> sample code provided in the JavaDoc to create and show a JFXPanel there's a >> good chance the JFXPanel will get focus before the scene has been set. To >> ensure AWT always treats the JFXPanel as an active IME client we return a >> stub version of the InputMethodRequests object if there's no scene. AWT will >> continue to ask for the InputMethodRequests and once the scene has been set >> the panel will return a non-stub version. > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > Switched to local array variables Noticed a (possibly unrelated) problem - Upon first launch , the IME window appears in the bottom right corner instead of near the text field. Dismiss, type - the windows appears where it's supposed to be: <img width="515" alt="Screenshot 2024-01-19 145505" src="https://github.com/openjdk/jfx/assets/107069028/7b284bab-9963-4292-95f6-3c535343a890";> the fix seems to work on window 11 (with one abovementioned problem). ------------- PR Comment: https://git.openjdk.org/jfx/pull/1337#issuecomment-1901265779 PR Comment: https://git.openjdk.org/jfx/pull/1337#issuecomment-1901267645
