On Mon, 29 Jan 2024 14:26:01 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> Added a utility method to run code on the FX thread if it's not already, and 
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add null parent checks

modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 976:

> 974:     }
> 975: 
> 976:     private void playFromStartOnFxThread() {

Maybe change this (and the other `playFrom* methods`) to `xxxImpl` as well?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1352#discussion_r1469816588

Reply via email to