On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Update tests One more thing I tried: I reverted the changes to the animation implementation, going back to the current JavaFX 22 behavior of throwing an exception if start, stop, etc is called on a background thread, and the tests still pass. It looks like the executor service is catching the exception, which is interfering with using an uncaught exception to flag an error. Instead of registering an uncaught exception handler for the test thread, you might wrap the runnable in another runnable with a try / catch and set the "failed" flag, etc., from there? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1352#issuecomment-1915363091
