> Turning on warnings-as-errors for the macOS glass native code. Deprecated > declarations are excluded and still appear as warnings. > > In the code that tries to locate the application's dock icon there were three > instances where `NO` was being passed into a method that required a pointer > to a `BOOL`, not a `BOOL`. I suspect the intent was to check that the path > pointed to an existing file but not a directory. Since JavaFX has gone this > long without screening out directories correctly I decided not to fix that > behavior except at the very end. > > The only other changes of note are sending some NSNotification objects to > delegate API's that require them even though we know they're ignored on the > other side. It was the easiest way to get rid of the warning.
Martin Fox has updated the pull request incrementally with two additional commits since the last revision: - Work-around for using a call not present in the Xcode 13.3 SDK. - Need correctly formed NSNotification when running tests ------------- Changes: - all: https://git.openjdk.org/jfx/pull/687/files - new: https://git.openjdk.org/jfx/pull/687/files/862067d8..ee8877d6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=687&range=04 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=687&range=03-04 Stats: 14 lines in 1 file changed: 4 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jfx/pull/687.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/687/head:pull/687 PR: https://git.openjdk.org/jfx/pull/687
