On Mon, 12 Feb 2024 20:48:22 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Work-around for using a call not present in the Xcode 13.3 SDK. >> - Need correctly formed NSNotification when running tests > > modules/javafx.graphics/src/main/native-glass/mac/GlassApplication.m line 655: > >> 653: // try again using Java generic icon (this icon >> might go away eventually ?) >> 654: iconPath = [NSString stringWithFormat:@"%s", >> "/System/Library/Frameworks/JavaVM.framework/Resources/GenericApp.icns"]; >> 655: } > > I presume you removed this because it is obsolete code? I do note that the > file in question is no longer there, so this seems fine. Yes, I think it's obsolete. I haven't seen an icon file in the JavaVM framework since I started working on JavaFX years ago. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/687#discussion_r1488159498
