On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac <[email protected]> wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
> [recommended](https://developer.apple.com/design/human-interface-guidelines/images#Best-practices)
> for some platforms.
>
> I tested this manually on Windows with "300%" UI scale factor, and verified
> `@2x` still works on macOS.
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/ImageStorageTest.java
line 78:
> 76: };
> 77: for (String[] names : imageNames) {
> 78: String name2x = ImageTools.getScaledImageName(names[0],
> scale);
Minor: maybe rename this variable to `nameScaled` or similar (since it isn't
always 2x any more)?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1429#discussion_r1540003814
