On Tue, 26 Mar 2024 21:27:49 GMT, drmarmac <d...@openjdk.org> wrote:

>> This PR extends the range of hi-res images that are loaded via naming 
>> convention, now including scale factors higher than `@2x`. 
>> Supporting these is already being 
>> [recommended](https://developer.apple.com/design/human-interface-guidelines/images#Best-practices)
>>  for some platforms.
>> 
>> I tested this manually on Windows with "300%" UI scale factor, and verified 
>> `@2x` still works on macOS.
>
> drmarmac has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Change name2x to nameScaled

The fix looks good to me. I confirm that the updated test fails without the fix 
and passes with the fix.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1429#pullrequestreview-1961877522

Reply via email to