On Wed, 27 Mar 2024 13:51:46 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> drmarmac has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove outdated comment > > modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java > line 773: > >> 771: .collect(Collectors.toList()); >> 772: >> 773: sortedNewIndices.forEach(this::set); > > Why do the double-iteration pattern here and not do the `peek` operation in a > `forEach` like in the other 2 places? `forEach` is void, so we can not return a list afterwards. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1430#discussion_r1542143935
