On Wed, 27 Mar 2024 23:21:34 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> `forEach` is void, so we can not return a list afterwards. > > You don't need to return a list, you create it ahead of time like was done in > line 167 > > List<Integer> indices = new ArrayList<>(); > > and the add the elements in `forEach`. > Why do the double-iteration pattern here and not do the `peek` operation in a > `forEach` like in the other 2 places? Yes, if the usage of `forEach` in previous 2 places are correct then I would like to see similar change here as well. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1430#discussion_r1542358972
