On Thu, 23 May 2024 14:54:36 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not inside `Tooltip`, but >> inside the `TooltipBehaviour`. So the very first `Tooltip` gets processed >> correctly, but after no `Tooltip` will be processed by CSS before showing, >> resulting in the set `-fx-show-delay` to not be applied immediately. >> >> Added a bunch of headful tests for the behaviour since there were none >> before. > > Marius Hanl has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Implement applyStylesheetFromOwner(..) and use it instead to ensure > correct CSS processing for the Tooltip Node. > - Merge branch 'master' of https://github.com/openjdk/jfx into > 8296387-tooltip-css > - Allow Tooltip to process the owner styles first so that also global > stylesheets are considered for the e.g. tooltip show-delay > - JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first > tooltip that is shown before it is displayed Strange: I still see the same issue described in https://github.com/openjdk/jfx/pull/1394#issuecomment-1986520680 (the very first tooltip after updating stylesheet uses the old value) ------------- PR Comment: https://git.openjdk.org/jfx/pull/1394#issuecomment-2128039109
