On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X concept when >> the window appears). The change is to ignore the configure events (happens >> when location or size changes) until window is mapped. Before map java is >> notified in the `set_bounds` function. >> >> This seems to happen on newer versions of linux distros. >> >> 2) Specific to KDE, in the case of the example provided, when an MODAL >> window pops, it calls `set_enabled` `false` on the child (or all other >> windows if APPLICATION_MODAL) which causes it to update the window >> constraints. When maximized, the constraints where applied anyways, causing >> the window to still be maximized but not show as maximized. The change is to >> not apply constraints when not floating (meaning floating on the screen - >> not maximized, fullscreen or iconified). > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev excludes the unrelated > changes brought in by the merge/rebase. The pull request contains seven > additional commits since the last revision: > > - Merge branch 'refs/heads/master' into 8332222 > - Should still report location > - Fix > - Teste > - Teste > - Teste > - Fix 8332222 Initial comments: 1. the description says this fixes two issues. do we have two JBS tickets? if so, please add the other ticket to this PR 2. the description in JDK-8332222 is insufficient: missing steps to reproduce, expected, and observed behavior. Please update both PR and the ticket(s). ------------- PR Comment: https://git.openjdk.org/jfx/pull/1460#issuecomment-2174206604
