On Mon, 15 Jul 2024 21:12:35 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:

> Initial implementation of the protocol.

modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 53:

> 51:     [rolesMap setObject:@"JFXCheckboxAccessibility" forKey:@"CHECK_BOX"];
> 52:     [rolesMap setObject:@"JFXCheckboxAccessibility" 
> forKey:@"TOGGLE_BUTTON"];
> 53:     [rolesMap setObject:@"JFXStaticTextAccessibility" forKey:@"TEXT"];

are these keys mapped to AccessibleRole.java enum?  if so,
1. should we add a comment stating that (and possibly add a comment in 
AccessibleRole as well?
2. are we going to keep adding roles to this block as we go along?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1507#discussion_r1679810873

Reply via email to