On Tue, 16 Jul 2024 17:41:18 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Initial implementation of the protocol. > > modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line > 53: > >> 51: [rolesMap setObject:@"JFXCheckboxAccessibility" forKey:@"CHECK_BOX"]; >> 52: [rolesMap setObject:@"JFXCheckboxAccessibility" >> forKey:@"TOGGLE_BUTTON"]; >> 53: [rolesMap setObject:@"JFXStaticTextAccessibility" forKey:@"TEXT"]; > > are these keys mapped to AccessibleRole.java enum? if so, > 1. should we add a comment stating that (and possibly add a comment in > AccessibleRole as well? > 2. are we going to keep adding roles to this block as we go along? 1. Yes, these are linked to the JFX accessible roles defined in that enum. I can add comment here - not sure about the AccessibleRole, it is a definition that might be used for more than one platform so linking platform specific implementation from there sound incorrect; 2. Yes, as we are converting more and more functionality to the new API we are going to add roles implementations to this block until we have no roles not covered with the new API. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1507#discussion_r1680405200
