On Tue, 16 Jul 2024 17:47:11 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix formatting and spelling > > modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java > line 43: > >> 41: import static org.junit.Assert.assertFalse; >> 42: import static org.junit.Assert.assertTrue; >> 43: import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; > > We have a general "best practice" to not mix JUnit 4 and JUnit 5 calls in the > same test class. how did I miss that??? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679838717
