On Tue, 16 Jul 2024 18:13:37 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> how did I miss that???
>
> Worth noting is that PR #1503 also uses JUnit 5 for its new tests, and in a 
> non-trivial manner (not easy to replace). Maybe the best thing to do is to 
> convert this test class to JUnit 5?

Maybe we should ask people to convert to junit5 every time they modify a test.

I know we usually ask not to combine different issues in one PR, but given the 
fact that we are changing the tests there is no (or little) associated risk of 
regression or merge conflicts.  What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679850304

Reply via email to