On Tue, 25 Jun 2024 21:47:42 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> This PR considers the horizontal scroll events that can be generated on a >> trackpad, on an horizontally sided `TabPane` control (top or bottom), adding >> to the existing vertical scroll events from mouse wheel and trackpad, to >> scroll its tabs. >> >> Therefore, scrolling a `TabPane` will behave in the same way that >> `ScrollBar` does regarding those same events and control orientation >> (vertical/horizontal). > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Add tests for all four sides I am ok with fixing the direction of vertical scrolling in a separate ticket, as well as RTL reversal of the horizontal scrolling, also as a separate ticket. Left a couple of minor comments, otherwise looks good. I'll re-approve if you decide to make changes. modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java line 1345: > 1343: } > 1344: } > 1345: please remove unnecessary newline ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1486#pullrequestreview-2197767859 PR Review Comment: https://git.openjdk.org/jfx/pull/1486#discussion_r1690429539
