On Thu, 31 Oct 2024 15:20:47 GMT, Andy Goryachev <[email protected]> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.java
> line 1063:
>
>> 1061: ** That way there in no information leaked.
>> 1062: */
>> 1063: catch (java.net.URISyntaxException e) {
>
> are you sure the change is equivalent?
>
> For example, the old code catches `URISyntaxException` and
> `PrivilegedActionException` returning `null`, but the new code does not,
> unless I am mistaken.
See my previous comment. This entire block is dead code that cannot possibly be
reached in the absence of a security manager.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1824866712
